search

prettier / prettier-regression-testing

Automates the prettier/prettier regression checks with GitHub Actions.
11 stars 9 forks source link

For #12359 and #12362 #153

Open fisker opened 2 years ago

fisker commented 2 years ago

Run #12359

fisker commented 2 years ago

Run #12362

github-actions[bot] commented 2 years ago

prettier/prettier#12359 VS prettier/prettier@main

Diff (332 lines) ```diff diff --git ORI/excalidraw/src/components/LibraryUnit.tsx ALT/excalidraw/src/components/LibraryUnit.tsx index 46b0e8d..630ec32 100644 --- ORI/excalidraw/src/components/LibraryUnit.tsx +++ ALT/excalidraw/src/components/LibraryUnit.tsx @@ -107,13 +107,15 @@ export const LibraryUnit = ({ }} /> {adder} - {id && elements && (isHovered || isMobile || selected) && ( - onToggle(id, event)} - className="library-unit__checkbox" - /> - )} + {id && + elements && + (isHovered || isMobile || selected) && ( + onToggle(id, event)} + className="library-unit__checkbox" + /> + )}
); }; diff --git ORI/prettier/website/playground/Playground.js ALT/prettier/website/playground/Playground.js index 2228960..29a2484 100644 --- ORI/prettier/website/playground/Playground.js +++ ALT/prettier/website/playground/Playground.js @@ -259,13 +259,14 @@ class Playground extends React.Component { checked={editorState.showSecondFormat} onChange={editorState.toggleSecondFormat} /> - {editorState.showDoc && debug.doc && ( - this.getMarkdown({ doc: debug.doc })} - > - Copy doc - - )} + {editorState.showDoc && + debug.doc && ( + this.getMarkdown({ doc: debug.doc })} + > + Copy doc + + )}
) : ( Children.map(children, (button: ReactElement) => diff --git ORI/react-admin/packages/ra-ui-materialui/src/list/ListView.tsx ALT/react-admin/packages/ra-ui-materialui/src/list/ListView.tsx index 2d02752..41e40cf 100644 --- ORI/react-admin/packages/ra-ui-materialui/src/list/ListView.tsx +++ ALT/react-admin/packages/ra-ui-materialui/src/list/ListView.tsx @@ -62,11 +62,12 @@ export const ListView = (props: ListViewProps) => { })} key={version} > - {bulkActionButtons !== false && bulkActionButtons && ( - - {bulkActionButtons} - - )} + {bulkActionButtons !== false && + bulkActionButtons && ( + + {bulkActionButtons} + + )} {children && // @ts-ignore-line cloneElement(Children.only(children), { diff --git ORI/react-admin/packages/ra-ui-materialui/src/list/SimpleList.tsx ALT/react-admin/packages/ra-ui-materialui/src/list/SimpleList.tsx index 95869c9..4c373c8 100644 --- ORI/react-admin/packages/ra-ui-materialui/src/list/SimpleList.tsx +++ ALT/react-admin/packages/ra-ui-materialui/src/list/SimpleList.tsx @@ -224,8 +224,9 @@ export type FunctionToElement = ( id: Identifier ) => ReactNode; -export interface SimpleListProps - extends Omit { +export interface SimpleListProps< + RecordType extends Record = Record +> extends Omit { className?: string; classes?: ClassesOverride; hasBulkActions?: boolean; diff --git ORI/react-admin/packages/ra-ui-materialui/src/list/SingleFieldList.tsx ALT/react-admin/packages/ra-ui-materialui/src/list/SingleFieldList.tsx index 3727fa4..5709895 100644 --- ORI/react-admin/packages/ra-ui-materialui/src/list/SingleFieldList.tsx +++ ALT/react-admin/packages/ra-ui-materialui/src/list/SingleFieldList.tsx @@ -155,8 +155,9 @@ SingleFieldList.propTypes = { resource: PropTypes.string, }; -export interface SingleFieldListProps - extends HtmlHTMLAttributes { +export interface SingleFieldListProps< + RecordType extends Record = Record +> extends HtmlHTMLAttributes { className?: string; classes?: ClassesOverride; component?: string | ComponentType; diff --git ORI/typescript-eslint/packages/experimental-utils/src/ts-eslint/Rule.ts ALT/typescript-eslint/packages/experimental-utils/src/ts-eslint/Rule.ts index cf3c5b8..1ffd7c5 100644 --- ORI/typescript-eslint/packages/experimental-utils/src/ts-eslint/Rule.ts +++ ALT/typescript-eslint/packages/experimental-utils/src/ts-eslint/Rule.ts @@ -136,8 +136,9 @@ interface ReportDescriptorBase { // we disallow this because it's much better to use messageIds for reusable errors that are easily testable // readonly desc?: string; } -interface ReportDescriptorWithSuggestion - extends ReportDescriptorBase { +interface ReportDescriptorWithSuggestion< + TMessageIds extends string, +> extends ReportDescriptorBase { /** * 6.7's Suggestions API */ diff --git ORI/typescript-eslint/packages/typescript-estree/src/create-program/WatchCompilerHostOfConfigFile.ts ALT/typescript-eslint/packages/typescript-estree/src/create-program/WatchCompilerHostOfConfigFile.ts index 565f584..2783750 100644 --- ORI/typescript-eslint/packages/typescript-estree/src/create-program/WatchCompilerHostOfConfigFile.ts +++ ALT/typescript-eslint/packages/typescript-estree/src/create-program/WatchCompilerHostOfConfigFile.ts @@ -27,8 +27,9 @@ interface CachedDirectoryStructureHost extends DirectoryStructureHost { } // https://github.com/microsoft/TypeScript/blob/5d36aab06f12b0a3ba6197eb14e98204ec0195fb/src/compiler/watch.ts#L548-L554 -interface WatchCompilerHostOfConfigFile - extends ts.WatchCompilerHostOfConfigFile { +interface WatchCompilerHostOfConfigFile< + T extends ts.BuilderProgram, +> extends ts.WatchCompilerHostOfConfigFile { onCachedDirectoryStructureHostCreate( host: CachedDirectoryStructureHost, ): void; diff --git ORI/vega-lite/src/axis.ts ALT/vega-lite/src/axis.ts index 0a5c6eb..bf83d73 100644 --- ORI/vega-lite/src/axis.ts +++ ALT/vega-lite/src/axis.ts @@ -344,8 +344,9 @@ export type AxisConfig = Guide & disable?: boolean; }; -export interface Axis - extends AxisConfigBaseWithConditionalAndSignal, +export interface Axis< + ES extends ExprRef | SignalRef = ExprRef | SignalRef +> extends AxisConfigBaseWithConditionalAndSignal, Guide { /** * Mark definitions for custom axis encoding. diff --git ORI/vega-lite/src/spec/facet.ts ALT/vega-lite/src/spec/facet.ts index 807bf0b..eeaaedd 100644 --- ORI/vega-lite/src/spec/facet.ts +++ ALT/vega-lite/src/spec/facet.ts @@ -9,8 +9,10 @@ import {BaseSpec, GenericCompositionLayoutWithColumns, ResolveMixins} from './ba import {GenericLayerSpec, NormalizedLayerSpec} from './layer'; import {GenericUnitSpec, NormalizedUnitSpec} from './unit'; -export interface FacetFieldDef - extends TypedFieldDef { +export interface FacetFieldDef< + F extends Field, + ES extends ExprRef | SignalRef = ExprRef | SignalRef +> extends TypedFieldDef { /** * An object defining properties of a facet's header. */ @@ -96,8 +98,10 @@ export function isFacetMapping( /** * Facet mapping for encoding macro */ -export interface EncodingFacetMapping - extends FacetMapping> { +export interface EncodingFacetMapping< + F extends Field, + ES extends ExprRef | SignalRef = ExprRef | SignalRef +> extends FacetMapping> { /** * A field definition for the (flexible) facet of trellis plots. * @@ -113,8 +117,11 @@ export function isFacetFieldDef(channelDef: ChannelDef): cha /** * Base interface for a facet specification. */ -export interface GenericFacetSpec, L extends GenericLayerSpec, F extends Field> - extends BaseSpec, +export interface GenericFacetSpec< + U extends GenericUnitSpec, + L extends GenericLayerSpec, + F extends Field +> extends BaseSpec, GenericCompositionLayoutWithColumns, ResolveMixins { /** ```
github-actions[bot] commented 2 years ago

prettier/prettier#12362 VS prettier/prettier@main

  • babel/babel@36a5ac4145be44b5dbbe2e8a70d1d0e7dc32ba43
  • vuejs/eslint-plugin-vue@10dd1a99aa983754deb76383b224d48ebb2cbe91
  • excalidraw/excalidraw@afa7932c9b25980534012b1ef85a6e9b5743b95c
  • prettier/prettier@0e42acb49b36c0ddb47a860f168558ede7afa33f
  • marmelab/react-admin@5395b1394207bff5ea8dbd0d474f21bcc5b1ff99
  • typescript-eslint/typescript-eslint@833f8221ce00aecb7d08c519bab9568353850f48
  • vega/vega-lite@675653dc6b2d4708a8987cd921fb7bf64b5b1bf1

diff --git ORI/vega-lite/src/mark.ts ALT/vega-lite/src/mark.ts
index 1270686..5a27f5d 100644
--- ORI/vega-lite/src/mark.ts
+++ ALT/vega-lite/src/mark.ts
@@ -599,10 +599,8 @@ export interface RelativeBandSize {
 }

 // Point/Line OverlayMixins are only for area, line, and trail but we don't want to declare multiple types of MarkDef
-export interface MarkDef<
-  M extends string | Mark = Mark,
-  ES extends ExprRef | SignalRef = ExprRef | SignalRef
-> extends GenericMarkDef<M>,
+export interface MarkDef<M extends string | Mark = Mark, ES extends ExprRef | SignalRef = ExprRef | SignalRef>
+  extends GenericMarkDef<M>,
     Omit<
       MarkConfig<ES> &
         AreaConfig<ES> &
fisker commented 2 years ago

Run #12362

github-actions[bot] commented 2 years ago

prettier/prettier#12362 VS prettier/prettier@main

  • babel/babel@36a5ac4145be44b5dbbe2e8a70d1d0e7dc32ba43
  • vuejs/eslint-plugin-vue@10dd1a99aa983754deb76383b224d48ebb2cbe91
  • excalidraw/excalidraw@afa7932c9b25980534012b1ef85a6e9b5743b95c
  • prettier/prettier@0e42acb49b36c0ddb47a860f168558ede7afa33f
  • marmelab/react-admin@5395b1394207bff5ea8dbd0d474f21bcc5b1ff99
  • typescript-eslint/typescript-eslint@833f8221ce00aecb7d08c519bab9568353850f48
  • vega/vega-lite@675653dc6b2d4708a8987cd921fb7bf64b5b1bf1

diff --git ORI/vega-lite/src/mark.ts ALT/vega-lite/src/mark.ts
index 1270686..5a27f5d 100644
--- ORI/vega-lite/src/mark.ts
+++ ALT/vega-lite/src/mark.ts
@@ -599,10 +599,8 @@ export interface RelativeBandSize {
 }

 // Point/Line OverlayMixins are only for area, line, and trail but we don't want to declare multiple types of MarkDef
-export interface MarkDef<
-  M extends string | Mark = Mark,
-  ES extends ExprRef | SignalRef = ExprRef | SignalRef
-> extends GenericMarkDef<M>,
+export interface MarkDef<M extends string | Mark = Mark, ES extends ExprRef | SignalRef = ExprRef | SignalRef>
+  extends GenericMarkDef<M>,
     Omit<
       MarkConfig<ES> &
         AreaConfig<ES> &
fisker commented 2 years ago

I added a test for the diff above, why I can't reproduce this?

@sosukesuzuki @thorn0 Any clue?

fisker commented 2 years ago

Ah, sorry. I figured out, they use a different printWidth.