search

prettier / prettier-vscode

Visual Studio Code extension for Prettier
https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
MIT License
5.04k stars 446 forks source link

Remove prettier.useTabs and prettier.tabWidth #3323

Closed neorth closed 1 week ago

neorth commented 2 months ago

Is your feature request related to a problem? Please describe. I have seen confusion around the tab size settings in vscode so many times now and think it's time ro reconsider removing these two prettier settings. The implications around this change was previously discussed in #1515 and the two possible alternatives were clearly explained in this comment: https://github.com/prettier/prettier-vscode/issues/1515#issuecomment-802304888

This change would close #1859

Sure, there will be some frustration from those who have previously changed the prettier-specific settings but my guess is those are far fewer than the ones getting confused over why the setting in the status bar doesn't correspond with the actual indentation getting applied by prettier.

Describe the solution you'd like Remove prettier.useTabs and prettier.tabWidth in favour of editor.insertSpaces and editor.tabSize

Describe alternatives you've considered Keeping it as today

github-actions[bot] commented 2 weeks ago

This issue has been labeled as stale due to inactivity. Reply to keep this issue open.