search

prettier / prettier

Prettier is an opinionated code formatter.
https://prettier.io
MIT License
49.4k stars 4.36k forks source link

Find an open-source "real world" React app and add it to our snapshots #2918

Open suchipi opened 7 years ago

suchipi commented 7 years ago

There was a bug introduced in the 1.7.1 release that we would have caught in a real app pretty quickly, but we missed it.

If we could find a medium-to-large open-source React app to include in our snapshot suite, then we could see when we introduce changes that break things.

I say React because then we would see how JSX formats. Once we have better Vue support, it would make sense to add a vue app to the suite, too etc.

Ideally it'd be an app with:

AKA a production, "real world" app.

hawkrives commented 7 years ago

I can volunteer either of the apps I work on, https://github.com/hawkrives/gobbldygook or https://github.com/StoDevX/aao-react-native - they're both formatted with prettier, although I need to take a bit of time to upgrade them to 1.7.

I don't know how large of an app you're looking for, though; they might be too large.

Edit with a bit more detail: Gobbldygook is a React app, with webpack, styled-components, jest, redux, flow, and Babel.

AAO-React-Native is a React Native app with jest, flow, glamorous, and redux.

suchipi commented 7 years ago

Both look great to me- I actually would like to include both, unless the other collaborators don't want to take the size hit.