Open jocelynlecomte opened 3 years ago
I have a similar problem but it just returns "Git Revision null"
@TomCockram same same. What's the environment where you get that null? Also in a git action?
$ npx pretty-quick --check --branch develop && ng lint
🔍 Finding changed files since git revision null.
Command failed with exit code 2 (ENOENT): git diff --name-only --diff-filter=ACMRTUB
spawnSync git ENOENT
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Maybe related to https://github.com/azz/pretty-quick/issues/129?
@TomCockram same same. What's the environment where you get that null? Also in a git action?
$ npx pretty-quick --check --branch develop && ng lint 🔍 Finding changed files since git revision null. Command failed with exit code 2 (ENOENT): git diff --name-only --diff-filter=ACMRTUB spawnSync git ENOENT error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
I get this behaviour when performing this in a GitHub action.
Same here
Same here, I have files staged. But there not detected. Could it have something to do with the fact that I'm in a monorepo not in the Root directory?
Same here, I have files staged. But there not detected. Could it have something to do with the fact that I'm in a monorepo not in the Root directory?
I'm working in a root directory and got this issue so don't think it's that.
The issue is, that pretty-quick
uses git
under the hood. If you use alpine
or ubuntu slim
images, they usually don't have git
command out of the box. Make sure, that you install git
in your CI runner.
i was also getting the git revision null
message when i ran npx pretty-quick --staged
Needed to add the --branch main
flag since it compares against master
by default (as it says in the docs - which i did not read).
Happens the same to me on Azure DevOps (while working fine locally)
i was also getting the
git revision null
message when i rannpx pretty-quick --staged
Needed to add the
--branch main
flag since it compares againstmaster
by default (as it says in the docs - which i did not read).
I had an issue where pretty-quick
was including files in our monorepo in parent folders relative to where I was running it, but I hadn't changed. Turns out using this flag against the target branch fixed my issue. Thanks!
How to use this in GitHub Actions with actions/checkout@v3? I have tried to set fetch-depth=0 but still no changes found. Locally the same command works nicely so I guess the problem is in Github's way to do checkout.
same problem here with "Found 0 changed files". i'm using this but it doesn't find changed files: run: npx -p prettier@3.0.2 -p pretty-quick@3.1.3 pretty-quick --staged --branch main
seems there is a bug, see here https://github.com/orgs/community/discussions/39880
A minimal but runnable online reproduction is required.
I'm working with node 12.18.1, prettier@2.0.5, and pretty-quick@3.1.0 on a windows 10 computer. I have this strange behaviour:
then
but
Any idea ?