search

prettier / pretty-quick

⚡ Get Pretty Quick
https://npm.im/pretty-quick
MIT License
2.22k stars 83 forks source link

feat!: support prettier v3 #182

Closed JounQin closed 8 months ago

JounQin commented 8 months ago

close #164

Waiting https://github.com/prettier/pretty-quick/pull/180#issuecomment-1894971802

cc @SukkaW

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 7ef996405e4c99aeab942cf6a44354fe5c24a7ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | pretty-quick | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 8 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 8 months ago

size-limit report 📦

Path Size
src/index.ts 981 B (+2.73% 🔺)
codecov-commenter commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5055759) 85.45% compared to head (7ef9964) 86.04%.

Files Patch % Lines
src/processFiles.ts 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #182 +/- ## ========================================== + Coverage 85.45% 86.04% +0.59% ========================================== Files 8 9 +1 Lines 165 172 +7 Branches 49 41 -8 ========================================== + Hits 141 148 +7 Misses 21 21 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SukkaW commented 8 months ago

@JounQin What about bumping the minimum Node.js version as well? Currently pretty-quick supports Node.js >= 10.

JounQin commented 8 months ago

@JounQin What about bumping the minimum Node.js version as well? Currently pretty-quick supports Node.js >= 10.

I've already bumped to >=14.8.0 for top level await. See also https://github.com/prettier/pretty-quick/pull/182/files#diff-795f9cd3f5b7c419d737cc16d57e6c86dac57b1e2656da6d436645bdbd264fc6R15

(But Should we do this? Or keep >=14 same as prettier)

https://github.com/prettier/pretty-quick/pull/182/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R13

I decided to support >=14 because the efforts are just small.

taylorkline commented 4 months ago

Should prettier/prettier#15337 be reverted and pretty-quick be added back to the docs of pre-commit solutions?