prettier / stylelint-config-prettier

Turns off all rules that are unnecessary or might conflict with prettier.
MIT License
373 stars 23 forks source link

Remove deprecated rules for Stylelint v15+ #139

Closed karlhorky closed 1 year ago

karlhorky commented 1 year ago

Hi there, first of all, thanks for the continued work in the Prettier / Stylelint ecosystems, these tools are amazing for DX! 🙌

Running Stylelint v15+ with stylelint-config-prettier@9.0.4 (latest at time of submission) yields the following deprecation warnings - maybe these rule configurations could be removed:

Deprecation warnings:
 - The "at-rule-name-case" rule is deprecated.
 - The "at-rule-name-newline-after" rule is deprecated.
 - The "at-rule-semicolon-space-before" rule is deprecated.
 - The "at-rule-name-space-after" rule is deprecated.
 - The "at-rule-semicolon-newline-after" rule is deprecated.
 - The "block-closing-brace-empty-line-before" rule is deprecated.
 - The "block-closing-brace-newline-after" rule is deprecated.
 - The "block-closing-brace-newline-before" rule is deprecated.
 - The "block-closing-brace-space-after" rule is deprecated.
 - The "block-closing-brace-space-before" rule is deprecated.
 - The "block-opening-brace-newline-after" rule is deprecated.
 - The "block-opening-brace-newline-before" rule is deprecated.
 - The "block-opening-brace-space-after" rule is deprecated.
 - The "block-opening-brace-space-before" rule is deprecated.
 - The "color-hex-case" rule is deprecated.
 - The "declaration-bang-space-after" rule is deprecated.
 - The "declaration-bang-space-before" rule is deprecated.
 - The "declaration-block-semicolon-newline-after" rule is deprecated.
 - The "declaration-block-semicolon-newline-before" rule is deprecated.
 - The "declaration-block-semicolon-space-after" rule is deprecated.
 - The "declaration-block-semicolon-space-before" rule is deprecated.
 - The "declaration-block-trailing-semicolon" rule is deprecated.
 - The "declaration-colon-newline-after" rule is deprecated.
 - The "declaration-colon-space-after" rule is deprecated.
 - The "declaration-colon-space-before" rule is deprecated.
 - The "function-comma-newline-after" rule is deprecated.
 - The "function-comma-newline-before" rule is deprecated.
 - The "function-comma-space-after" rule is deprecated.
 - The "function-comma-space-before" rule is deprecated.
 - The "function-max-empty-lines" rule is deprecated.
 - The "function-parentheses-newline-inside" rule is deprecated.
 - The "function-parentheses-space-inside" rule is deprecated.
 - The "linebreaks" rule is deprecated.
 - The "max-empty-lines" rule is deprecated.
 - The "max-line-length" rule is deprecated.
 - The "media-feature-colon-space-after" rule is deprecated.
 - The "media-feature-colon-space-before" rule is deprecated.
 - The "media-feature-name-case" rule is deprecated.
 - The "media-feature-parentheses-space-inside" rule is deprecated.
 - The "media-query-list-comma-newline-after" rule is deprecated.
 - The "media-query-list-comma-newline-before" rule is deprecated.
 - The "media-query-list-comma-space-after" rule is deprecated.
 - The "media-query-list-comma-space-before" rule is deprecated.
 - The "no-empty-first-line" rule is deprecated.
 - The "no-eol-whitespace" rule is deprecated.
 - The "no-extra-semicolons" rule is deprecated.
 - The "no-missing-end-of-source-newline" rule is deprecated.
 - The "number-leading-zero" rule is deprecated.
 - The "number-no-trailing-zeros" rule is deprecated.
 - The "property-case" rule is deprecated.
 - The "selector-attribute-brackets-space-inside" rule is deprecated.
 - The "selector-attribute-operator-space-after" rule is deprecated.
 - The "selector-attribute-operator-space-before" rule is deprecated.
 - The "selector-combinator-space-after" rule is deprecated.
 - The "selector-combinator-space-before" rule is deprecated.
 - The "selector-descendant-combinator-no-non-space" rule is deprecated.
 - The "selector-list-comma-newline-after" rule is deprecated.
 - The "selector-list-comma-newline-before" rule is deprecated.
 - The "selector-list-comma-space-after" rule is deprecated.
 - The "selector-list-comma-space-before" rule is deprecated.
 - The "selector-max-empty-lines" rule is deprecated.
 - The "selector-pseudo-class-case" rule is deprecated.
 - The "selector-pseudo-class-parentheses-space-inside" rule is deprecated.
 - The "selector-pseudo-element-case" rule is deprecated.
 - The "string-quotes" rule is deprecated.
 - The "unicode-bom" rule is deprecated.
 - The "unit-case" rule is deprecated.
 - The "value-list-comma-newline-after" rule is deprecated.
 - The "value-list-comma-newline-before" rule is deprecated.
 - The "value-list-comma-space-after" rule is deprecated.
 - The "value-list-comma-space-before" rule is deprecated.
 - The "value-list-max-empty-lines" rule is deprecated.
 - The "indentation" rule is deprecated.
jiadesen commented 1 year ago

me too

shannonmoeller commented 1 year ago

Wow. That's pretty much every rule. I'll have to take a look at what changed in v15 and loop back.

shannonmoeller commented 1 year ago

Looks like this was intentional. Version 15 deprecates all style rules so this package will become obsolete in version 16.

https://stylelint.io/migration-guide/to-15#:~:text=Additionally%2C%20you%20may%20no%20longer%20need%20to%20extend%20Prettier%27s%20Stylelint%20config

If you're using v15 and are not making use of any style rules you no longer need this config plugin.

I'll update the README.

karlhorky commented 1 year ago

Great, thanks @shannonmoeller ! I'll remove stylelint-config-prettier from our configs and dependencies too.