prettier / vim-prettier

A Vim plugin for Prettier
MIT License
1.78k stars 138 forks source link

Deletes comments in Ruby files #335

Open coaxial opened 2 years ago

coaxial commented 2 years ago

Do you want to request a feature or report a bug? A bug

What is the current/expected behavior? current: deletes comments. Expected: leave comments alone

What version of vim-prettier are you using - (output of :PrettierVersion) ? 1.0.0-beta

What version of prettier are you using - (output of :PrettierCliVersion) ? 2.3.1

What is your prettier executable path - (output of :PrettierCliPath) ? ~/.vim/plugged/vim-prettier/node_modules/.bin/prettier

Did this work in previous versions of vim-prettier and/or prettier ? I don't know

With let g:prettier#autoformat=1, create a new buffer and set ft=ruby. Saving this buffer:

# My comment

puts 'hello'

Will modify it to:

puts 'hello'

My config file:

Plug 'prettier/vim-prettier', { 'do': 'npm install'  }
let g:prettier#autoformat = 1
let g:prettier#autoformat_config_present = 0
let g:prettier#autoformat_require_pragma = 0
let g:prettier#exec_cmd_async = 1
let g:prettier#quickfix_enabled = 0

For those affected, a temporary fix in your .vimrc:

autocmd BufRead,BufNewFile  *.rb let g:prettier#autoformat = 0
alexstan67 commented 1 year ago

Hi same problem for me... Comments disappearing as well as shebang line #! /usr/bin/env ruby

marcosmcz commented 1 year ago

I have the same issue :(

My solution was to use Neovims null-ls.nvim package for ruby.

victorsptt commented 1 year ago

What version of the @prettier/plugin-ruby npm package are you using?

There is a bug in versions of the @prettier/plugin-ruby npm package lower than 1.0 that removes comments from some parts of the code.

You can try updating your version of the @prettier/plugin-ruby to >=1.0.0 <4.0.0 and see if it solves the error.

npm install --save-dev @prettier/plugin-ruby@">=1.0.0 <4.0.0"