search

preumich / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

php: fetch_(access|request)_token changed to new_(access|request)_token in SimpleOAuthDataStore but not OAuthDataStore #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Create a class implementing the OAuthDataStore interface
2. Use it for an OAuth server

What is the expected output? What do you see instead?

The OAuthServer class should call the "fetch_" functions, since that's
what's documented for the interface. Instead, it calls the "new_"
functions, which are what's actually implemented in the Simple class. If
the new_ functions aren't implemented, PHP throws an unimplemented-method
exception.

Probably the best fix would be to simply change the "fetch_" functions to
"new_" functions in the abstract OAuthDataStore class, so that implementers
know what they should really implement. It's more of a documentation error
than anything else.

What version of the product are you using? On what operating system?

PHP library, latest version as of this issue.

Please provide any additional information below.

Original issue reported on code.google.com by evan.pro...@gmail.com on 2 Jun 2008 at 7:58

GoogleCodeExporter commented 9 years ago

Original comment by leah.culver on 8 Jul 2008 at 4:38

GoogleCodeExporter commented 9 years ago 
this is pretty closely related to 
http://code.google.com/p/oauth/issues/detail?id=32
as that whole piece needs an overhaul

Original comment by andyster on 15 Jul 2008 at 10:37

GoogleCodeExporter commented 9 years ago

Original comment by andyster on 15 Jul 2008 at 10:39

GoogleCodeExporter commented 9 years ago

Original comment by andyster on 15 Jul 2008 at 11:17

GoogleCodeExporter commented 9 years ago 
Since rev. 888 there is now a consistency in function naming. Still not great, 
but at least names called, names in 
the "interface" and names in the simple implementation are the same..

Original comment by morten.f...@gmail.com on 5 Feb 2009 at 10:20

GoogleCodeExporter commented 9 years ago 
Closing. It should still be converted to an interface. But this bug is no 
longer valid..

Original comment by morten.f...@gmail.com on 18 May 2009 at 6:04