preumich / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

PHP Library fails to load POST data if content-type includes charset #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Send POST request with Content-Type: 
application/x-www-form-urlencoded;charset=UTF-8

What is the expected output? What do you see instead?
That POST-variables should be registered as parameters to the call, but they 
aren't because the 
library currently just checks if Content-Type == 
application/x-www-form-urlencoded

So I've changed == to strstr that checks if application/x-www-form-urlencoded 
is included in 
the Content-Type header

I've attached a patch, and it is applied to my current branch of changes which 
can be reviewed at
http://code.google.com/p/oauth/source/diff?
show=review&format=side&old_path=/code/php/OAuth.php&old_rev=874&path=/code/bran
ch
es/fangel/php/OAuth.php&r=875&spec=svn875

-Morten

Original issue reported on code.google.com by morten.f...@gmail.com on 30 Jan 2009 at 5:19

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in revision 888
http://code.google.com/p/oauth/source/detail?r=888

Original comment by morten.f...@gmail.com on 5 Feb 2009 at 10:18