search

previewict / gchartphp

Automatically exported from code.google.com/p/gchartphp
0 stars 0 forks source link

Variable not initialized before concat #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

--- gChart2.php (revision 10)
+++ gChart2.php (working copy)
@@ -75,7 +75,7 @@
                }

                protected function concatUrl(){
-                       $fullUrl .= $this->baseUrl;
+                       $fullUrl = $this->baseUrl;
                        $fullUrl .= "cht=".$this->types[$this->type];
                        $fullUrl .= "&chs=".$this->width."x".$this->height;

Original issue reported on code.google.com by forbes...@gmail.com on 19 Dec 2007 at 8:52

GoogleCodeExporter commented 9 years ago 
Hi! 

There is a simple solution for this, just add 
$fullUrl='';
right after
protected function concatUrl(){

You should have this piece of code:

        protected function concatUrl(){
            $fullUrl='';
            $fullUrl .= $this->baseUrl;
            $fullUrl .= "cht=".$this->types[$this->type];
            $fullUrl .= "&chs=".$this->width."x".$this->height;

Sincerely yours,
Alexei Shulga

Original comment by alexei.s...@gmail.com on 20 Dec 2007 at 2:29

GoogleCodeExporter commented 9 years ago 
I sent you the "svn diff gChart2.php" fix - I think it is a better fix but not 
that 
important.

Original comment by forbes...@gmail.com on 20 Dec 2007 at 9:08

GoogleCodeExporter commented 9 years ago 
Hello!

Same problem and same decision (add `$fullUrl='';`)

Why you don't commit diff?

Original comment by Sergey.K...@gmail.com on 7 Aug 2008 at 4:05

GoogleCodeExporter commented 9 years ago 
the code is abandoned, I guess...

Original comment by webwe...@gmail.com on 18 Aug 2008 at 9:52

GoogleCodeExporter commented 9 years ago 
Fixed on ver. 13

Original comment by bardellie on 11 May 2010 at 6:14