prey / gdpr_rails

Rails Engine for the GDPR compliance

https://preyproject.com

MIT License

626 stars 62 forks source link

Rails 6 active storage #40

Closed michelson closed 5 years ago

michelson commented 5 years ago

adds rails 6 support
adds active storage support
adds a legacy mode for paperclip
a slim matrix for travis ci

michelson commented 5 years ago

38

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 149

90 of 91 (98.9%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 94.199%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/models/policy_manager/portability_request.rb	2	3	66.67%
<!--	Total:	90	91	98.9%	-->

Totals
Change from base Build 122:	0.5%
Covered Lines:	958
Relevant Lines:	1017

Pull Request Test Coverage Report for Build 133

90 of 91 (98.9%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 94.199%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/models/policy_manager/portability_request.rb	2	3	66.67%
<!--	Total:	90	91	98.9%	-->

Totals
Change from base Build 122:	0.5%
Covered Lines:	958
Relevant Lines:	1017

Pull Request Test Coverage Report for Build 133

90 of 91 (98.9%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 94.199%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/models/policy_manager/portability_request.rb	2	3	66.67%
<!--	Total:	90	91	98.9%	-->

Totals
Change from base Build 122:	0.5%
Covered Lines:	958
Relevant Lines:	1017

💛 - Coveralls

mrsweaters commented 5 years ago

Rails 6 has been released, is this ready to merge in?

michelson commented 5 years ago

Hi , I've updated dependences on the rails6 (from 6.0.0-rc1 to 6.0.0) in appraisal gemfile in order to release. Unfortunately there is a failing build on travis. it seems the problem is from travis platform but I will dig further on this.

meanwhile you can try this branch on your rails 6 application.

michelson commented 5 years ago

released in rubygems as 0.5.0 version

mrsweaters commented 5 years ago

Sweet! Yeah I didn't see any issues in my app. Thanks for this!