Closed mrsweaters closed 4 years ago
@mrsweaters Thanks! could you commit the appraisals Gemfile.lock in order to CI to pass
Thanks!
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
app/helpers/policy_manager/terms_helper.rb | 1 | 60.0% | ||
spec/controllers/policy_manager/user_portability_requests_controller_spec.rb | 1 | 95.45% | ||
spec/dummy/app/models/another_user.rb | 1 | 55.56% | ||
spec/dummy/app/models/user.rb | 1 | 55.56% | ||
app/helpers/policy_manager/application_helper.rb | 4 | 56.52% | ||
spec/controllers/policy_manager/portability_requests_controller_spec.rb | 4 | 90.38% | ||
spec/controllers/policy_manager/terms_controller_spec.rb | 4 | 89.8% | ||
spec/controllers/policy_manager/categories_controller_spec.rb | 19 | 58.33% | ||
<!-- | Total: | 35 | --> |
Totals | |
---|---|
Change from base Build 154: | -3.2% |
Covered Lines: | 925 |
Relevant Lines: | 1018 |
I updated the appraisal but now I'm getting an issue looking for a manifest file:
Failure/Error: //= link terms_manifest.js
ActionView::Template::Error:
couldn't find file 'terms_manifest.js'
I see a policy_manager_manifest.js but no terms_manifest.js.
I updated the appraisal but now I'm getting an issue looking for a manifest file:
Failure/Error: //= link terms_manifest.js ActionView::Template::Error: couldn't find file 'terms_manifest.js'
I see a policy_manager_manifest.js but no terms_manifest.js.
@mrsweaters - I pulled the repo down and couldn't find any other reference besides that failure in gdpr_rails/spec/dummy/app/assets/config/manifest.js
that mentions 'terms_manifest.js' ... other than deleting that line, not sure what to do unless @michelson has any guidance.
Thanks for the contribution! 🥇
Edit:
Super weird, my PR #47 didn't fail on that issue. Perhaps it needs to just rerun & it's generated somewhere? https://travis-ci.org/prey/gdpr_rails/builds/638550797
@michelson @masonhensly Oh interesting! Yeah maybe it is cached in Travis somewhere.
@mrsweaters - would you be able to make a one line change to the MR so that Travis is retriggered? 🤞 everything would be green then.
If you're too busy, do you mind me forking your branch and submitting it as a new MR to get it to green?
Thanks again
yeah that didn't seem to help, feel free to have at it.
This will allow us to update Rails to the recent security-patched versions of Rails.
Closes: https://github.com/prey/gdpr_rails/issues/44