search

prey / gdpr_rails

Rails Engine for the GDPR compliance
https://preyproject.com
MIT License
626 stars 62 forks source link

Rails 6 minor + Sprockets Config Update (assets.rb) #48

Closed masonhensley closed 4 years ago

masonhensley commented 4 years ago

Rebased against #47 (documentation update) and giving a shot at Travis tests to carry the torch on mrsweater's work in https://github.com/prey/gdpr_rails/pull/45

Will close #47 if this goes green.

Fixes https://github.com/prey/gdpr_rails/issues/44

FYI

Notes about documentation update:

... Quick documentation update for future contributors based on feedback in #46 & #45

Update

Ready for review. Thanks for the project 🎉

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 174

Files with Coverage Reduction New Missed Lines %
app/helpers/policy_manager/terms_helper.rb 1 60.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 154: 0.1%
Covered Lines: 957
Relevant Lines: 1016
💛 - Coveralls
mrsweaters commented 4 years ago

@patriciojofre @michelson @matipacheco Is there anything we need to change to get this merged? I know it can be a pain in the ass maintaining a repo, so we want to help as much as possible here (and hopefully not be a hindrance).

michelson commented 4 years ago

I think we are ready to merge, just note the change on .update_attributes with .update , is .update compatible with rails 5.1.4 ?

Le damos @patriciojofre ?

mrsweaters commented 4 years ago

In Rails 5.1.4 update_attributes is an alias of update so it should be fine. https://api.rubyonrails.org/v5.1.4/classes/ActiveRecord/Persistence.html

mrsweaters commented 4 years ago

Can we get this merged in?

psnider30 commented 4 years ago

Any update on when this is getting merged?

patriciojofre commented 4 years ago

sorry guys, PR merged! thanks for contribute to gdpr rails!