Closed EtienneDepaulis closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/policy_manager/config.rb | 4 | 8 | 50.0% | ||
<!-- | Total: | 5 | 9 | 55.56% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
test/dummy/app/models/user.rb | 1 | 55.56% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 28: | -0.5% |
Covered Lines: | 737 |
Relevant Lines: | 792 |
Hi @EtienneDepaulis , this is a great addition to the library. I will test this in our implementation before merge, but overall it looks good to me. best!
Hello guys,
on our app we have a
User
model for our users and anAdminUser
model for our admin users. This PR adds the possibility to specify this behavior in the configuration:I had to fix the display of the navbar as when you are logged in as an AdminUser you don't have any terms to accept (which is a common user action).
Todo :
User
direct usage instead ofConfig.user_resource
(fixed one in the exporter)I've also taken the liberty to:
mysql2
version restrictionWhat do you think of this feature ?