prezi / pride

Manages a pride of Gradle modules
Other
71 stars 13 forks source link

locate projects with manipulated project names #93

Closed pepov closed 10 years ago

pepov commented 10 years ago

We have some projects where we have modified subproject names (we add a prefix) and it would be nice if we could support it in the pride as well. Absolute paths are kind of ugly, but at least works precisely.

My questions:

lptr commented 10 years ago

Hey, thanks for the patch. I think this is a valid use-case that Pride should support. It looks to me that your solution is in the right direction.

I'd like to ask for a couple of changes:

About the compatibility issue: Pride 0.9 is not compatible, unfortunately, with previous versions. You need to use Pride plugin 0.9+ to work with Pride 0.9. I'll try to minimize breaking changes like this in the future, but currently agility was more important. For now I'd recommend upgrading to Pride 0.9.2 across the board.

One of the ways to stay more compatible is to split off the project model extraction from the Pride plugin: https://github.com/prezi/pride/issues/94

About tests: there aren't much, as you can see. It would be awesome if you could contribute some nice tests, for this or any other part of the tool. :)

pepov commented 10 years ago
lptr commented 10 years ago

Ah, sorry about the spaces then. I'll fix those after we've merged this pull request.