Fix - Implement fix for layout shift when overflow is hidden

sumairq commented 3 months ago

Solves issue #1139

Description

This pull request addresses a layout shift issue triggered when the categories button in the navigation is clicked. The problem occurs due to the dynamic nature of the scroll bar, which dissapears when the overflow is set to hidden and causes unexpected layout adjustments, impacting user experience negatively.

Changes Made

Modified the CategoriesNavDesktop component and implemented a simple solution that adds a margin equal to the width of the missing scrollbar to compensate when the overflow property is set to hidden.

Impact

Resolves the layout shift issue, counters the abrupt shifts caused by the dissapearance of the scroll bar.
Improves the visual consistency and stability of the interface when interacting with the categories button.

solution2

Testing

Manually verified that the layout remains stable and consistent under various scenarios, including different viewport sizes.

Your feedback is much appreciated :raised_hands:

vercel[bot] commented 3 months ago

@sumairq is attempting to deploy a commit to the Prezly Team on Vercel.

A member of the Team first needs to authorize it.

sumairq commented 3 months ago

Hi @MohammadxAli @kudlajz @e1himself :wave:

I would appreciate it if you could take some time to review this pull request and provide your feedback. Your insights would be valuable in improving the quality of the code.

Thanks in advance for your time and attention! :raised_hands:

sumair765 commented 3 months ago

@MohammadxAli My original account got hacked , someone was able to gain total access of it . Even the 2FA was changed. I have taken up the matter with github and opened a ticket. I hope they are able to help. For now, kindly close this PR and I will be opening a new one incorporating your suggestions.

Thanks a bunch, Sumair Qaisar

MohammadxAli commented 3 months ago

@MohammadxAli My original account got hacked , someone was able to gain total access of it . Even the 2FA was changed. I have taken up the matter with github and opened a ticket. I hope they are able to help. For now, kindly close this PR and I will be opening a new one incorporating your suggestions.

Thanks a bunch, Sumair Qaisar

Hey @sumairq, I'm sorry that your account got hacked.

After discussing it as a team, we've decided not to move this PR forward. Unfortunately, we also won't be accepting any PRs from @smith-business or yourself. Our primary objective is security first, and given the current situation, we're uncomfortable making any further progress with this PR, knowing that your devices or accounts might be at risk of distributing harmful software.

sumair765 commented 3 months ago

Hi @MohammadxAli, @kudlajz , @e1himself

Let me clarify the complete picture about what happened.

First of all, my account never got compromised before. It's the only time. Call it a lapse of judgement on my part. Secondly, I have reinstalled my operating system to ensure nothing malicious remains within my system.

The problem happened when a mysterious "recruiter" tried to reach out to me through linkedIn . They appeared to be legit. They shared a figma design with me and had a website.

That fake recruiter wanted me to clone their repo as a pretext for preparing me for the supposed "interview". As soon as I cloned the repository and installed the packages to run the project in my local environment. I recieved automated emails from Github that some activity is happening in my github account. Someone changed the email from "sumairqaisar992@gmail.com" my email to "smithdylan0919@gmail.com". All of sudden I lost access to my account. I thought it promt to convey the message wherever I was collaborating through my newly created account (totally uncompromised and safe).

Luckily, the person who stole my account changed the username so I was able to create a fresh account with my old username.

I did some research, and found out that apparently the hacker did session hijacking on my account by getting me to open malicious file/script that he then used to dump my session and move it to their browser.

Anyway, I have learned the hard lesson about keeping my accounts secure.

It is my humble request to you to not punish me for something I was a victim of.

I have made sure that nothing malicious remains within my system or browser by reinstalling my ubuntu operating system and have resolved to not clone or run any project locally unless I am 100% certain of the company's legitimacy.

I want to reemphasize that my devices or accounts are not at risk of distributing any harmful software whatsoever.

Therefore, I humbly request you to kindly reconsider your decision and give me a chance to contribute.

Here is my LinkedIn

https://www.linkedin.com/in/sumairq/

I can provide a reference from the team I worked with at Mozilla as an open-source developer in an attempt to restore trust.
I have graduated from Microverse Coding bootcamp and can get references from them as well.
Or any other way to prove that I am a legitimate developer aiming to contribute to prezly and by no means attempting to compromise its code.

If you have any questions about this, please feel free to ask.

Regards, Sumair Qaisar

sumairq commented 3 months ago

@MohammadxAli After rebasing the PR seems to be showing other recent commits as well.

For reference to the latest changes I made, look at the last commit (Refactor solution (making it simpler))

I was reading about this. Got an explanation here: https://github.com/orgs/community/discussions/51948#discussioncomment-5536787

sumairq commented 2 months ago

Hi @MohammadxAli :wave:

Cleaned the commit history in my PR. Now it's ready for review. :+1:

prezly / theme-nextjs-bea