Closed kudlajz closed 2 months ago
vercel[bot]
commented
2 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| theme-nextjs-bea-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 4, 2024 11:22am |
kudlajz
commented
2 months ago We're adding functionality to the theme app that is only necessary for the rock app.
But isn't that the case with literally every functionality? I mean, the themes are built in order to support stuff we have in the app. They have to work well with Prezly, it's not like we're building these themes to be their standalone thing, is it?
Either way, I would recommend posting your concerns in Linear, Discourse or some other platform where other people can see it, otherwise no one is gonna read it here on Github 🙂
More logic that we need to add and maintain in every theme app in order for it to work with the rock app properly.
That is true currently, but I think the plan is to get rid of Greta and Lena and merge their "differences" into Bea as customization options so we end up with one theme that is much more customizable rather than have several slightly different themes. That should make the maintenance much easier in the long term.
We need to be able to preserve the scroll position when live previewing the theme, but since it's not possible to access the scroll position of the iframe, we need this extra code to provide the scroll position when scrolling happens.
Similarly, we also need to listen to the messages from the parent so we can restore the scroll position after the iframe is reloaded.