search

prezto-inactive-community-fork / prezto

THIS FORK HAS SHUT DOWN – use the original!
https://github.com/sorin-ionescu/prezto
MIT License
115 stars 18 forks source link

Modules/docker #49

Closed akarzim closed 7 years ago

akarzim commented 7 years ago

Add some concise aliases for docker, docker-machine and docker-compose.

AFAIK, theses aliases will not shadow other system commands or prezto’s module aliases.

paulmelnikow commented 7 years ago

For the record: this is a repost of sorin-ionescu/prezto#1147

malikoth commented 7 years ago

Exciting!

paulmelnikow commented 7 years ago

I don't want to set a precedent for adding lots of new modules. However Docker is widely used, so I'd like to include it in Prezto.

I'm interested to hear what other people think.

malikoth commented 7 years ago

I'm very much in favor of including this. Docker seems to have swept the world, and it would be nice to have this module maintained to make it easier and faster to work with Docker.

paulmelnikow commented 7 years ago

Looks good to me.

maximbaz commented 7 years ago

I don't want to set a precedent for adding lots of new modules.

@paulmelnikow why not? #52 might take quite a long time, why prevent adding new modules until it's done? When #52 is ready, all the external plugins will likely be purged anyway.

paulmelnikow commented 7 years ago

Just a heads up that reviewing and merging are on pause because Sorin is open to adding maintainers to the original (#44).

paulmelnikow commented 7 years ago

@belak has started merging changes at the original. I sincerely hope this is merged! It looks like the original PR now needs to be rebased, as it seems to be tracking the same branch as this one.

Think the simplest thing would be to make a new branch, and a new PR at the original.

belak commented 7 years ago

There's a bit of discussion that I'd like to see in the new PR before it gets merged... things like what aliases are worth including and how they should be organized. In short, I feel like the prezto git module aliases get a bunch of things right and I'd like to see a similar structure with the docker aliases. Anyway, discussion at the new PR (and it looks like this has been rebased against the original prezto to make that PR work), so this can probably be closed.

See https://github.com/sorin-ionescu/prezto/pull/1147

paulmelnikow commented 7 years ago

Merged via sorin-ionescu/prezto#1147.