price-format / Jquery-Price-Format

jQuery Price Format Plugin is useful to format input fields and HTML elements as prices. For example, if you type 123456, the plugin updates it to US$ 1,234.56. It is costumizable, so you can use other prefixes, separators, suffixes, plus sign, minus sign and so on. Check out the examples below.
http://price-format.github.io/Jquery-Price-Format/
MIT License
239 stars 118 forks source link

Best practices and code style #74

Open cuducos opened 7 years ago

cuducos commented 7 years ago

As suggested in #71:

I would like to suggest a minimum contribution guide with our agreement on code stye and best practices for this project.

Long story short my suggestions would be:

  • ES6 compliant
  • any consolidate code style guide
  • something like Browserify and Babel to generate the browser/CDN .min.js (haven't checked the current gulpfile.js but maybe it's already there)

By consolidated I mean anything compatible with JSLlint. IMHO in spite f the semicolons I'd go with Airbnb.

What do you think about it? Here is how I plan to review this PR:

  1. we could agree on something among these lines in terms of best practices and code style
  2. we add that to README.md (or create CONTRIBUTING.md if it gets too long once again)
  3. finally I'll have stuff other than my own opinion to dive into code

Hey @flaviosilveira, jump in!

nandomoreirame commented 7 years ago

Hey, @cuducos welcome back bro! 🤘

Yes! I approve your all suggestions and complement the check list:


As for this Pull Request (#71), I think it's just to remove prototype files and implement some things from ES6 in GulpJS files...

We can continue this discussion for new projects ;)