priceline / design-system

Priceline.com Design System
https://priceline.github.io/design-system/
MIT License
722 stars 119 forks source link

fix(AIR-61584): avoid render the hidden children #1472

Closed CalebBoLiuPriceline closed 8 months ago

CalebBoLiuPriceline commented 8 months ago

The carouse would render the children twice, which caused the same children component with same test-id appear twice.

Before fix

Screenshot 2024-03-11 at 10 44 06 AM

After fix

Screenshot 2024-03-11 at 10 45 23 AM
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.72%. Comparing base (544b97d) to head (cfd2914).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1472 +/- ## ======================================= Coverage 94.72% 94.72% ======================================= Files 145 145 Lines 10868 10868 Branches 680 680 ======================================= Hits 10295 10295 Misses 561 561 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.