search

priceline / design-system

Priceline.com Design System
https://priceline.github.io/design-system/
MIT License
722 stars 119 forks source link

Site 22740 - Fix overflow behavior for next-landing express deal dialog #1477

Closed Bsoong closed 7 months ago

Bsoong commented 7 months ago

Ticket: https://priceline.atlassian.net/browse/SITE-22740

While attempting to bump design system up in NL, the dialog behavior for our express deal was showing the overflow issue again. this is the code to fix said issue via a default true set prop that we will set false as to not disrupt others that rely on the overflowY: scroll.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.76%. Comparing base (4daf2c3) to head (0c95f85). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1477 +/- ## ======================================= Coverage 94.76% 94.76% ======================================= Files 146 146 Lines 11036 11039 +3 Branches 698 698 ======================================= + Hits 10458 10461 +3 Misses 565 565 Partials 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.