search

priceline / design-system

Priceline.com Design System
https://priceline.github.io/design-system/
MIT License
722 stars 119 forks source link

Fix close button bug and add max/min width props to Popover #1507

Closed craigpalermo closed 3 months ago

craigpalermo commented 3 months ago

This also corrects the prop type expected for renderContent.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (136733b) to head (280b988). Report is 3 commits behind head on main.

Files Patch % Lines
packages/core/src/Popover/Popover.tsx 20.00% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1507 +/- ## ========================================== - Coverage 93.81% 93.58% -0.24% ========================================== Files 149 149 Lines 11248 11264 +16 Branches 685 686 +1 ========================================== - Hits 10552 10541 -11 - Misses 677 704 +27 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.