priceline / design-system

Priceline.com Design System
https://priceline.github.io/design-system/
MIT License
722 stars 119 forks source link

Add text-shadows to theme #348

Closed jes708 closed 4 years ago

jes708 commented 6 years ago

x=0, y=1, blur=2 color=black seems to be recurring. Let's add it to theme and add support for it to be used in the Text and Heading components.

BeniCheni commented 5 years ago

Confirmed with @wesleymartin85 on the the text shadow style as text-shadow: 0 1px 2px 0 rgba(0,0,0,0.5); for normal font sizes to start with.

Potentially, @wesleymartin85 would define the large font sizes for text and the related text shadow style for in further comment.

wesleymartin85 commented 5 years ago

@BeniCheni @dansternfeld1 here is the design documentation for text shadows https://priceline.invisionapp.com/share/ZGRG7D6TFVP#/357099836Headings-_Text_Shadow and a screen shot since we are open source ;)

Screen Shot 2019-08-15 at 12 09 29 PM
James300 commented 4 years ago

Add text-shadows to theme