<Image> component does not take `width` like others

priceline / design-system

Priceline.com Design System

https://priceline.github.io/design-system/

MIT License

722 stars 119 forks source link

<Image> component does not take `width` like others #674

Closed bertya closed 4 years ago

bertya commented 4 years ago

Image component does not do styled-system interpolation on the width prop, instead, it's treated as a pure HTML attribute, which is not consistent to other behaviors.

vtjoseph commented 4 years ago

Hi @bertya @wesleymartin85, is this still a valid issue? @unscsprt and I validated this on storybook and it looks responsive.Thanks

sdalonzo commented 4 years ago

@vtjoseph @bertya @wesleymartin85 @unscsprt It seems like @unscsprt fixed this in a PR into the v3 branch, which has been merged. https://github.com/priceline/design-system/pull/653. Resolving this issue.