priceline / design-system

Priceline.com Design System
https://priceline.github.io/design-system/
MIT License
722 stars 119 forks source link

Reconsider use of icon in Banner component #714

Open jes708 opened 4 years ago

jes708 commented 4 years ago

Allow icon props, such as size, to be configurable. Remove presets named after colors, since different palettes will not translate the same Remove the showIcon prop since there will no longer be presets

https://github.com/priceline/design-system/blob/master/packages/core/src/Banner.js#L89

craigpalermo commented 4 years ago

Ideas discussed in WG: