Fix modal to not shift/move the page upon closing

priceline / design-system

Priceline.com Design System

https://priceline.github.io/design-system/

MIT License

722 stars 119 forks source link

Fix modal to not shift/move the page upon closing #737

Open EnoshAnwar opened 4 years ago

EnoshAnwar commented 4 years ago

When using the Modal component from pcln-modal on another application I noticed the page body shift to the left when closing the modal. This is something that can also be seen on priceline.com.

modal-issue

oliviertassinari commented 4 years ago

If it can help, you can have a look at the sources of Material-UI around how the library solves this issue.

craigpalermo commented 4 years ago

@oliviertassinari Thanks, that's an excellent suggestion! It seems like Material's modal has the behavior we want (at least in the context of their docs site), so I'll have to see what we can do to get closer to their implementation.