priceline / design-system

Priceline.com Design System
https://priceline.github.io/design-system/
MIT License
722 stars 119 forks source link

Pre-commit check for internal registry URLs should log offending files #874

Closed craigpalermo closed 4 years ago

craigpalermo commented 4 years ago

Is your feature request related to a problem? Please describe. To make debugging easier, no-internal-registry should log which package-lock.json files contain internal URLs so the developer can see which files they need to delete/update.

Describe the solution you'd like Should log which files it found that contain internal URLs.

bmansell commented 4 years ago

I think this one can be closed, I can see this is running on pre-commit and was able to find and correct my core/package-lock.json and types/package-lock.json files the other day thanks to this tool!

https://github.com/priceline/design-system/blob/b75b24e7bdd61bc2888a1f6f7327d119ea9371da/package.json#L80

https://github.com/priceline/design-system/blob/b75b24e7bdd61bc2888a1f6f7327d119ea9371da/githooks/no-internal-registry.js#L32

sdalonzo commented 4 years ago

as @pcln-brianna noted, @craigpalermo fixed this.