search

priceline / omni-slider

A multirange vanilla js slider
https://www.priceline.com
MIT License
63 stars 12 forks source link

eslint support issue - Parsing error: Illegal export declaration? #18

Closed ghost closed 8 years ago

ghost commented 8 years ago

Hello,

I experimented to gauge how supportive the eslint or language feature this code base supports with the following snippet in the screen.

I was unlucky to get a "yelling" for a eslint parsing error with a simple usage of export?

Parsing error: Illegal export declaration - Please see following IDE analysis and help the contributors to understand how supportive of es2015 language features this code base supports?

screen shot 2016-06-09 at 8 30 14 am
ghost commented 8 years ago

Hi @thehindenburg , heart that you are savvy with linter config and toolset. Do you know why the eslint would not support a simple export language feature?

joshbDev commented 8 years ago

When eslint was turned on, it was turned on without a .eslintconfig. I'm implementing Priceline's linter momentarily, you can follow that PR here: https://github.com/pricelinelabs/javascript/pull/1

chrisrng commented 8 years ago

This should be fixed with #20

ghost commented 8 years ago

Thanks guys. I will pay close attention to #20.

Let's enable full language feature support for at least es2015, if not es2016. I got a couple of ideas to implement the open issues using es2015 stuff to explore things. Need the linter to be easy on me. :)

joshbDev commented 8 years ago

This is the linter we're using internally which is taking full advantage of async/await and other es2016 features, so should be fully formed and ready for your future needs. :)