search

prici-io / prici

manage plans and pricing for any SaaS application
https://prici.io
MIT License
37 stars 5 forks source link

Bug/39 - nest guard has a type check problem with the SDK #41

Closed eladabramovich closed 6 months ago

eladabramovich commented 6 months ago

Resolve #39. The issue was that the type assigned to sdk property on IsAllowedGuardOptions interface includes the private members of the class but the type definition in index.d.ts that is used when passing the SDK instance to the guard sort of ignores any private member, so I changed the type definition to also ignore any private member.

netlify[bot] commented 6 months ago

Deploy Preview for dashing-meerkat-19c0fa ready!

Name Link
Latest commit 14b5c7aa9964c9a616908565061019d7adcaf214
Latest deploy log https://app.netlify.com/sites/dashing-meerkat-19c0fa/deploys/65ba1fc8a40ed60008a64e1f
Deploy Preview https://deploy-preview-41--dashing-meerkat-19c0fa.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidmeirlevy commented 6 months ago

Weird and funny solution, but it works.