priestc / giotto

Python web development simplified
BSD 2-Clause "Simplified" License
59 stars 10 forks source link

python-irclib use in IRC controller #10

Closed farces closed 11 years ago

farces commented 11 years ago

Switches from the hardcoded irc implementation (didn't work if latency was high) to python-irclib from https://bitbucket.org/jaraco/irc

Requires module: irc

Renames irc.py to irc_.py due to unresolvable conflict with python-irclib and preference for loading irc.py from the local namespace.

Still buggy and has a lot of the same issues that the original IRC controller had, such as crashes when parse_kwargs is given strange arguments.

farces commented 11 years ago

Just realised I stripped out part where private message invocations don't include the magic_token, so that is still required in there. Simple fix involves just checking magic_token in do_pubmsg and not in privmsg, which I might get around to shortly.