search

prihoda / AbNumber

Convenience Python APIs for antibody numbering using ANARCI
MIT License
80 stars 11 forks source link

Pip-installability #19

Open arogozhnikov opened 6 months ago

arogozhnikov commented 6 months ago

Hi David, I've challenged myself to move ANARCI from conda to pip, I've seen you previously have been working on same task in your fork.

you can find result here, currently mimics 2021.02.04, still requires hmmer binary installed https://github.com/arogozhnikov/microANARCI

It fails AbNumber tests (just as conda version). Question: why do you think that older version is more correct? Everyone seems to use the latest from conda.

prihoda commented 3 months ago

Hi @arogozhnikov,

I also made some effort to migrate to pyhmmer which enables pure pip install without hmmer dependency, I even created a PR to ANARCI repo but there was no response: https://github.com/oxpig/ANARCI/pull/38

Based on my tests it works, but it would definitely require more testing from their side.

About using version 2020.04.23 - at the time it was due to this bug, not sure if it has been fixed yet: https://github.com/oxpig/ANARCI/issues/17

arogozhnikov commented 3 months ago

thanks, that's looks like a gross issue for a numbering tool