prikhi / lightdm-mini-greeter

A Minimal, Configurable, Single-User GTK3 LightDM Greeter
GNU General Public License v3.0
541 stars 48 forks source link

Text colour option for "Password:" and such text #20

Closed parnmatt closed 6 years ago

parnmatt commented 6 years ago

Unless I am mistaken, but surely the default text colour option should style the password-label-text, and the incorrect password.

None of the style options change it for me; is this a bug? or is it a feaure yet to be added?

rrothermund commented 6 years ago

Having the same issue. Were you able to figure this out?

parnmatt commented 6 years ago

No, still waiting on @prikhi

golimpio commented 6 years ago

I was having the same issue on Manjaro, so I've made a small change that fixed the issue for me. Follow the diff code, in case you're willing to install it from source:

diff --git a/src/ui.c b/src/ui.c
index 0a61115..2334301 100644
--- a/src/ui.c
+++ b/src/ui.c
@@ -228,12 +228,12 @@ static void attach_config_colors_to_screen(Config *config)
     int css_string_length = asprintf(&css,
         "* {\n"
             "font: %s %s;\n"
+            "color: %s;\n"
         "}\n"
         "GtkLabel {\n"
-            "color: %s;\n"
             "font-weight: bold;\n"
         "}\n"
-        "GtkLabel#error {\n"
+        "#error {\n"
             "color: %s;\n"
         "}\n"
         "#background {\n"
golimpio commented 6 years ago

I also had an issue with the error message not being displayed in the correct color, the patch above fix it as well.

I just start using this app today, so I guess it was working before and some change in the recent GTK version has broken it.

arawden commented 6 years ago

Confirming that this is still broken (will add more specific version information in future)

prikhi commented 6 years ago

Sorry for the bouts of inactivity, this should be fixed now. Had to change GtkLabel to simply label. Will cut a new release for it soon.