Changed the MAX_VERSION to support Firefox 47

prikhi / pencil

DEPRECATED: Multiplatform GUI Prototyping/Wireframing

https://github.com/evolus/pencil

GNU General Public License v2.0

1.92k stars 193 forks source link

Changed the MAX_VERSION to support Firefox 47 #841

Closed valsr closed 7 years ago

valsr commented 8 years ago

Should we remove the max version directive, since this fix would need to reapplied every new firefox release?

rosera commented 7 years ago

Does the MAX_VERSION have any dependencies, other than checking on Firefox version? As the version number for Firefox will always be going up, it seems like this check is unnecessary from a version validation point of view.

prikhi commented 7 years ago

Should be fixed. I tried to keep it to versions I've tested but haven't had time to work on pencil for a while, especially since v3 exists now. If I have trouble keeping the maxVersion up to date, I'll just bump it up to 999 or something.