Closed jamsethoth closed 2 years ago
Hi! Why did you close the pull request? I think i can test and merge it into master.
Also, you don't need to copy everything from 1.5 to 1.6, only things that changed. All missing assets in 1.6 would be automatically loaded from default version (which is 1.5)
Yeah, I deleted it because I realized I could do it better, and then since my repo got screwed and I decided to be safe and just reclone and apply the changes again. I'll raise a pr today or tomorrow with the updates.
On Sun., Dec. 12, 2021, 4:55 p.m. Pavel Prikhodko, @.***> wrote:
Also, you don't need to copy everything from 1.5 to 1.6, only things that changed. All missing assets in 1.6 would be automatically loaded from default version (which is 1.5)
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/prikhodkop/kdm_story_app/pull/81#issuecomment-991977551, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRCW5UNPHQJNZC5ABQGDHDUQUK6BANCNFSM5J3RP4BQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Okay, I have raised a new PR
On Sun, Dec 12, 2021 at 5:07 PM James Irwin @.***> wrote:
Yeah, I deleted it because I realized I could do it better, and then since my repo got screwed and I decided to be safe and just reclone and apply the changes again. I'll raise a pr today or tomorrow with the updates.
On Sun., Dec. 12, 2021, 4:55 p.m. Pavel Prikhodko, < @.***> wrote:
Also, you don't need to copy everything from 1.5 to 1.6, only things that changed. All missing assets in 1.6 would be automatically loaded from default version (which is 1.5)
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/prikhodkop/kdm_story_app/pull/81#issuecomment-991977551, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRCW5UNPHQJNZC5ABQGDHDUQUK6BANCNFSM5J3RP4BQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Created new 1.6 version, updating all changed assets and adding new assets