search

prikryla / friendly_betting

1 stars 0 forks source link

FE - delete password in the profile section #26

Open prikryla opened 1 month ago

prikryla commented 1 month ago

@janmrakava IMHO there is no reason to display the actual user's password in the profile section. I'm suggesting some button that will redirect user to some form where he can change his password. WDYT? We can also implement some verification via email to confirm the edit process.

janmrakava commented 1 month ago

That's my mistake, that should be basic input with type=password, so user can just see the basic password template. But I forgot to add type, gonna fix it soon

prikryla commented 1 month ago

No worries, but still .. no need to leave it here, or..? Button for change password is enough I think.

janmrakava commented 1 month ago

Just check the Figma design, whole functionality is here. But well, maybe I can change it, im not sure, its matter of preference I guess

prikryla commented 1 month ago

I know that we have it in Figma, but think about it. If we use type=password, the password will be hidden and what's the reason to have it here? None I guess. If user wants to change password, he should be able to use some button, whatever, to redirect somewhere he can input new password and make the change.