search

primaeval / script.tvguide.fullscreen

tv guide fullscreen
GNU General Public License v2.0
25 stars 26 forks source link

bit more skin tweeking #20

Closed im85288 closed 8 years ago

im85288 commented 8 years ago

pops up a up next info for the next episode (I added defaults to the default/pip/dark) skins

iainsmacleod commented 8 years ago

Is there anyway that you can make the next up notification only visible when the media is playing, and in the foreground? For my skin it will appear behind the EPG due to the transparency I use.

im85288 commented 8 years ago

It should only be appearing when gui.py is in TV mode (so not when things like the OSD or EPG are being shown). Are you experiencing something different..or did I mis understand?

iainsmacleod commented 8 years ago

Yeah, I am experiencing it on EPG screen, maybe I should look at your visible commands - because you set it to false, and I simply changed it to true - maybe it needs conditions???

On Wed, Aug 24, 2016 at 9:53 AM, Ian Mclaughlin notifications@github.com wrote:

It should only be appearing when gui.py is in TV mode (so not when things like the OSD or EPG are being shown). Are you experiencing something different..or did I mis understand?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/20#issuecomment-242072120, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHojR3igb6B5ykOmxsOMalPtRkj6r_ks5qjEzxgaJpZM4JsAns .

primaeval commented 8 years ago

I got it on the epg screen once today too.

im85288 commented 8 years ago

There could well be a bug or two there I guess, but the logic should only kick off when in tv mode so not sure how it's shown on the EPG.

primaeval commented 8 years ago

I just added a couple of changes to fix it. Any action will close the up next popup. Select (enter) will also close the popup.

We'll have to have a look at whether all the commands are logical and consistent sometime.

primaeval commented 8 years ago

You could get it to stay in front of the epg if you set the time to a large number and press stop in tv mode.

im85288 commented 8 years ago

Ah yes of course, another way to resolve that would be to do a check on the mode in the while loop and if the mode was no longer tv close it. But having actions to close it makes sense too.

primaeval commented 8 years ago

The close on all actions catches everything. Is there any case where it doesn't make sense to close it?

im85288 commented 8 years ago

No, sounds good to me. I'll add in the check for tv mode at a later stage as a further safety check.