Skin changes

[iainsmacleod]

Wait for additional changes.

[iainsmacleod]

Should be good to merge

[primaeval]

Did you test every dialog on confluence?

[iainsmacleod]

I test loading, channels. main, menu, setup.

The main issue I have found that I was having was the cancel button for loading on Jarvis, on Krypton it if offset from it's requested location - so looks weird on Krypon, fine on Jarvis.

On Thu, Sep 15, 2016 at 4:05 PM, primaeval notifications@github.com wrote:

Did you test every dialog on confluence?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247437851, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHomBMz4MxfCIT3U5M29MrO1kveiUBks5qqaT5gaJpZM4J98Lc .

[iainsmacleod]

Also, programme list

On Thu, Sep 15, 2016 at 4:09 PM, Iain MacLeod iain.macleod@gmail.com wrote:

I test loading, channels. main, menu, setup.

The main issue I have found that I was having was the cancel button for loading on Jarvis, on Krypton it if offset from it's requested location - so looks weird on Krypon, fine on Jarvis.

On Thu, Sep 15, 2016 at 4:05 PM, primaeval notifications@github.com wrote:

Did you test every dialog on confluence?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247437851, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHomBMz4MxfCIT3U5M29MrO1kveiUBks5qqaT5gaJpZM4J98Lc .

[iainsmacleod]

Did you find any issues to prevent a merge?

[primaeval]

I was waiting for you to say everything was ok first. It looked like you needed to do something with the cancel button.

[iainsmacleod]

I don't think I can make it work in Jarvis and Krypton.

[primaeval]

What is wrong with it?

[iainsmacleod]

On Krypton the button seems to be offset from the coordinates I enter, so cancel doesn't lie in the button. So I center the text on top of a new image, because I also don't like how the button appears.

In Jarvis, it is fine.

[primaeval]

That is one of the reasons I try not to touch krypton at the moment. I found loads of bugs with the texture layout.

[iainsmacleod]

And that's why I sorted it for Jarvis, for your preference.

On Sep 16, 2016 3:24 PM, "primaeval" notifications@github.com wrote:

That is one of the reasons I try not to touch krypton at the moment. I found loads of bugs with the texture layout.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247685708, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHooo6ImQ5CgCR0r3x7A0h1pFgR799ks5qquzpgaJpZM4J98Lc .

[primaeval]

If all the other buttons line up ok with their textures can't you just copy their formatting rules to the Loading Cancel button?

[iainsmacleod]

I would think it would just work, my only assumption would be something is different in gui.py???

On Fri, Sep 16, 2016 at 3:31 PM, primaeval notifications@github.com wrote:

If all the other buttons line up ok with their textures can't you just copy their formatting rules to the Loading Cancel button?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247687412, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHone2PxMOItdb_LZgtdywWHq4dmx2ks5qqu6tgaJpZM4J98Lc .

[iainsmacleod]

Hid the button, but still works - should be good now.

[primaeval]

Is the cancel button wrong on the Default skin in Krypton too?

[iainsmacleod]

Default looks fine, I wonder if you specified a bigger button. I removed a lot of the other bits, the loading bar etc, maybe that had an effect?

[primaeval]

I don't think I touched the loading screen from the original except for the background.

[primaeval]

I tested it. You have taken out too much from the loading screen. It flashes up on every new page. There was some background texture that covers that unless it takes a long time. You might need to try it out on a lower end device if you don't see it on your dev system.

[iainsmacleod]

Are you suggesting your default skin does t show the loading screen when it is loading some items?

I see what you are talking about, but it is actually loading. I guess I could make a transparent background if media is playing.

What are you looking for?

On Sep 17, 2016 3:24 AM, "primaeval" notifications@github.com wrote:

I tested it. You have taken out too much from the loading screen. It flashes up on every new page. There was some background texture that covers that unless it takes a long time. You might need to try it out on a lower end device if you don't see it on your dev system.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247754936, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHosRyRd-qDvgtmwdxxdWQQO91Q1pQks5qq5WsgaJpZM4J98Lc .

[primaeval]

Do a comparison of paging down in the main epg with the Dark skin. Check out my master then your master and you should see that your latest changes flash up the pulsating loading icon when you page down. It didn't do it before.

[iainsmacleod]

I know what it is. There is an animation associated with the control, and there is a delay of 1.5 seconds. I guess, I'll put the animation delay back in - but 1.5 s seems pointlessly large. I think if there's is about 500ms I'm good. Let me know if that works for you.

Lowest system I have is Pi2

On Sep 18, 2016 3:56 PM, "primaeval" notifications@github.com wrote:

Do a comparison of paging down in the main epg with the Dark skin. Check out my master then your master and you should see that your latest changes flash up the pulsating loading icon when you page down. It didn't do it before.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247871463, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHonloS2yq2cZGqr7TqS1RbPzr2iETks5qrZeBgaJpZM4J98Lc .

[iainsmacleod]

Hmm. Found some scenarios it still blinks. Will leave at 1500 I guess.

On Sep 18, 2016 16:46, "Iain MacLeod" iain.macleod@gmail.com wrote:

I know what it is. There is an animation associated with the control, and there is a delay of 1.5 seconds. I guess, I'll put the animation delay back in - but 1.5 s seems pointlessly large. I think if there's is about 500ms I'm good. Let me know if that works for you.

Lowest system I have is Pi2

On Sep 18, 2016 3:56 PM, "primaeval" notifications@github.com wrote:

Do a comparison of paging down in the main epg with the Dark skin. Check out my master then your master and you should see that your latest changes flash up the pulsating loading icon when you page down. It didn't do it before.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/pull/73#issuecomment-247871463, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHonloS2yq2cZGqr7TqS1RbPzr2iETks5qrZeBgaJpZM4J98Lc .

[primaeval]

That's better. Thanks. I spent a lot of time early on trying to work out why I was getting headaches paging down in a dark room. I had to do some sneaky tricks to hide some of the epg when it was changing. It's still not perfect (for all skins) but its not too distracting now.