search

primaeval / script.tvguide.fullscreen

tv guide fullscreen
GNU General Public License v2.0
25 stars 26 forks source link

Dark footer #78

Closed primaeval closed 7 years ago

primaeval commented 8 years ago

@iainsmacleod Could you have a look at tidying up the Dark skin footer when you get the time: control 4602. This is the code in gui.py that sets its position and height to match up with the bottom of the epg rows. https://github.com/primaeval/script.tvguide.fullscreen/blob/1f9efef46996be7592665bf3460af57b630cb5bd/gui.py#L1661 dark footer2 dark footer

iainsmacleod commented 8 years ago

Was this meant to be directed at me, and if so - how would you like this to work? I mean you want to pull the info up ot the bottom, thus making the whole footer have to be dynamic - or did you want to fill the dead space over a certain size with an additional "empty" program space?

On Sat, Oct 1, 2016 at 4:06 AM, primaeval notifications@github.com wrote:

@im85288 https://github.com/im85288 Could you have a look at tidying up the Dark skin footer when you get the time: control 4602. This is the code in gui.py that sets its position and height to match up with the bottom of the epg rows. https://github.com/primaeval/script.tvguide.fullscreen/blob/ 1f9efef46996be7592665bf3460af57b630cb5bd/gui.py#L1661 [image: dark footer2] https://cloud.githubusercontent.com/assets/11716348/19012759/b3a60522-87be-11e6-829a-e2b5ce455d12.PNG [image: dark footer] https://cloud.githubusercontent.com/assets/11716348/19012760/b3aa713e-87be-11e6-92d4-dc202d968cc4.PNG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/issues/78, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHoljm_YRRBDMNirISXOWN7l9gcmU6ks5qvhSOgaJpZM4KLszw .

primaeval commented 8 years ago

It is confusing when you are both called Iain. Sorry.

Have a look at how it works in the Default skin and the gui.py link in the first post. The texture 4602 C_MAIN_FOOTER is resized and its top is moved to fit the footer section.

im85288 commented 8 years ago

I'm Ian without the I in the middle! But yeah I can imagine it's quite confusing as we are both have similar last names too! Hope everyone's doing well

iainsmacleod commented 8 years ago

Should be fixed now, it appears that you reference a setting based on the default skin, so I had to put a bunch of offsets.

Also, Ian - I'm doing well. Where are you from, Scottish heritage?

On Wed, Oct 5, 2016 at 4:45 AM, Ian Mclaughlin notifications@github.com wrote:

I'm Ian without the I in the middle! But yeah I can imagine it's quite confusing as we are both have similar last names too! Hope everyone's doing well

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/primaeval/script.tvguide.fullscreen/issues/78#issuecomment-251617011, or mute the thread https://github.com/notifications/unsubscribe-auth/AEAHoutbz-gVEhPmW1stJd1orm0pHAHvks5qw2ONgaJpZM4KLszw .

primaeval commented 8 years ago

Thanks. Hi Ian. Mainly fine. How are you.

iainsmacleod commented 7 years ago

This can be closed, right?

primaeval commented 7 years ago

If you are happy with it. Thanks.