search

primait / event_sourcing.rs

event sourcing framework in rust
51 stars 4 forks source link

Fix deployment --allow-dirty issue #177

Closed cottinisimone closed 1 year ago

cottinisimone commented 1 year ago

The [build])https://drone-1.prima.it/primait/event_sourcing.rs/451/1/4) that failed because of dirty directory. The issue is that .cargo directory should be ignored

cottinisimone commented 1 year ago

I would suggest you add a --allow-dirty flag instead

primait/umami#1074

.cargo specifies a bunch of cargo, and it's a directory you want to commit to git

Why do you think you want to commit a directory of cached things? .cargo directory is just a bunch of downloaded crates..

I think that --allow-dirty isn't that good because if something changes though all the steps (like the format, or the compilation or whatever) that should be committed in the source code, and not directly published..

Am i missing something?

MaeIsBad commented 1 year ago

I think that --allow-dirty isn't that good because if something changes though all the steps (like the format, or the compilation or whatever) that should be committed in the source code, and not directly published..

I thought allow-dirty would commit the clean state of the repo, but I was wrong, my bad.

Why do you think you want to commit a directory of cached things? .cargo directory is just a bunch of downloaded crates..

it is not, that's only a thing in the prima specific rust CI, because we set CARGO_HOME there. Normally .cargo contains the cargo config(https://doc.rust-lang.org/cargo/reference/config.html)

cottinisimone commented 1 year ago

I think that --allow-dirty isn't that good because if something changes though all the steps (like the format, or the compilation or whatever) that should be committed in the source code, and not directly published..

I thought allow-dirty would commit the clean state of the repo, but I was wrong, my bad.

Why do you think you want to commit a directory of cached things? .cargo directory is just a bunch of downloaded crates..

it is not, that's only a thing in the prima specific rust CI, because we set CARGO_HOME there. Normally .cargo contains the cargo config(https://doc.rust-lang.org/cargo/reference/config.html)

I saw this issue: https://github.com/rust-lang/cargo/issues/9398