search

primait / telepoison

MIT License
10 stars 5 forks source link

Move to opentelemetry-contrib #81

Open tsloughter opened 2 years ago

tsloughter commented 2 years ago

Would you be willing to submit this package to https://github.com/open-telemetry/opentelemetry-erlang-contrib/ ?

You can of course still maintain rights to the hex package and approval for any changes to the library with it in -contrib, but it makes it easier for users to find.

pdincau commented 2 years ago

Hey @tsloughter, we are already discussing this internally.

I'll come back to you as soon as we take a final decision! Thank you!

cpiemontese commented 1 year ago

Hi @tsloughter!

We tried reasoning about giving this project to the community and maybe retaining our CI/CD pipeline, but that's not really possible. The easiest thing (for us) would be to "give you the code", we could still review PRs and solve eventual issues, but we wouldn't have ownership anymore. If you think this is not convenient, another solution could be making one (or more) of us part of the opentelemetry organization and/or giving us grants on that repo, so we still could have a "relevant" impact on PRs and the evolution of the library.

What do you think?

tsloughter commented 1 year ago

@cpiemontese adding the code to -contrib you still get ownership. We use the AUTHORS file to provide github access per project in that repo to appropriate owners. You'll also have perms for hex publishing.

cpiemontese commented 1 year ago

But is there any automation in place or would we need to publish to hex manually? I don't know how other projects under -contrib are managed e.g. if there are actions in place that run on release creation or something like that

tsloughter commented 1 year ago

It is currently manual, with both the original authors and otel maintainers able to publish.

cpiemontese commented 1 year ago

Sorry for the n-th question but I'm trying to understand better :sweat_smile:

You said we'll retain "approval for any changes to the library with it in -contrib", does that mean we won't be able to merge PRs ourselves?

tsloughter commented 1 year ago

Hm, sadly I don't think that is possible without giving permission to merge for all PRs to the repo. Would be more than happy to have more contrib maintainers (we need it) ;), but github doesn't provide a way to only give merge rights for PRs that touch specific parts of the repo.

cpiemontese commented 1 year ago

Hi again @tsloughter, I think we are ready to move telepoison to opentelemetry-erlang-contrib. Is there a checklist or something of what has to be done (aside from opening a PR with the code contained in this library)?

tsloughter commented 1 year ago

Great! There is just this right now https://github.com/open-telemetry/opentelemetry-erlang-contrib/blob/main/CONTRIBUTING.md