search

primakov / precision-medicine-toolbox

Precision medicine toolbox
BSD 3-Clause "New" or "Revised" License
59 stars 19 forks source link

[suggestion] linting/pep8ting #7

Closed ivanzhovannik closed 2 years ago

ivanzhovannik commented 2 years ago

Hey @lavrovaliz @primakov - nice project!

My 5 kopeek - I wanted to propose a suggestion if you have time. I think the naming is not always PEP8-ed, it is easy to check with a linting tool, e.g.:

(my_env) PS C:\Packages> pylint .\precision-medicine-toolbox\pmtool\data_set.py --confidence HIGH
************* Module pmtool.data_set
precision-medicine-toolbox\pmtool\data_set.py:17:0: C0103: Class name "data_set" doesn't conform to PascalCase naming style (invalid-name)
precision-medicine-toolbox\pmtool\data_set.py:101:24: C0103: Variable name "rt" doesn't conform to snake_case naming style (invalid-name)

------------------------------------------------------------------
Your code has been rated at 9.82/10 (previous run: 4.11/10, +5.71)

So data_set -> DataSet should fix it. Everything else looks good :)

lavrovaliz commented 2 years ago

Solved