search

primalcurve / git2jss

Easily sync your scripts and EA's from a git repo with the JSS
MIT License
3 stars 3 forks source link

Feature request: Sync non-script EAs #2

Open mikedowler opened 4 years ago

mikedowler commented 4 years ago

One of the benefits of the git2jss workflow is having scripts/EAs under version control - git shows a history of all changes, so we can see when and by whom changes were made. In order for this to be really effective, we need to modify permissions on Jamf Pro so that admins cannot make changes directly in Jamf.

However, changing permissions on Jamf also prevents changes being made to non-script EAs. The sync.py and download.py scripts specifically exclude these from their scopes, so that they can't be changed using the git workflow. As a result, we end up not being able to change these EAs at all (unless we revert the permissions settings, which isn't great).

Could we please include non-script EAs in scope? I think this could be done by just removing the checks which skip EAs if no script is found, but I guess we might want to make it an option that can be enabled with a script attribute. (Also not sure if it would require changes to the JamfObject class). I'm happy to have a crack at a PR, if appropriate.

primalcurve commented 4 years ago

I haven't looking too deeply at download.py. I can take a look. It was pretty simple when I last looked at it. Watch me rewrite it 😅