search

primary-theme / obsidian

Comfy, playful but productive theme for Obsidian. "Primary instantly puts you in a relaxed state that opens the door to creativity and exploration. Wonderfully executed down to the smallest details,"
GNU General Public License v3.0
852 stars 38 forks source link

🐛 Fixed callout overflow #103

Closed xotea closed 2 years ago

xotea commented 2 years ago

📝 Description

When the callout only has a title the title component overflows because it's bottom border radii are 0.

image

You can fix this by setting overflow: hidden on the parent with .callout but it removes part of the shadow.

To avoid this I left the inset-shadow on the children and moved the other to the parent.

Hopefully it doesn't break anything else. I've just found this awesome theme and I haven't worked with Obsidian themes before.

ceciliamay commented 2 years ago

Oh forgot about overflow! Thanks for the contribution!! 💕🙌 I will check again later but I'll push this. Thank you so much for the kind words too and I'm so glad you're enjoying it!!

xotea commented 2 years ago

Hey @ceciliamay!

I see you reverted this PR in 4ee2aec2fcf647e6276209fb2d33fad208d42f5a.

If this was intentional, could you please tell me the the reason so I can see what I didn't think of and learn from it?

Thanks.

ceciliamay commented 2 years ago

Oh shoot - this was definitely not intentional. I think I forgot to fetch the change to my local repo before pasting my recent updates from the dev vault🤦‍♀️. Could you write the changes again and "re-pull"?

Tip: Please remember to compile scss/index.scss to obsidian.css everytime you make changes before PR so that the updates will reflect into Obsidian. If you have Sass already installed use sass --watch "scss/index.scss" "obsidian.css" terminal command inside the repo directory! If you don't know how to use Sass let me know and I'll compile it after merging your PR 😄 If you know how to automate this please let me know because I'm still learning how to use GitHub lol

xotea commented 2 years ago

Yes of course.

Unfortunately, I'm not that experienced in CI/CD either to recommend you a way to best automate this. 🙁