primary-theme / obsidian

Comfy, playful but productive theme for Obsidian. "Primary instantly puts you in a relaxed state that opens the door to creativity and exploration. Wonderfully executed down to the smallest details,"
GNU General Public License v3.0
980 stars 41 forks source link

Checkbox issue #111

Closed j-r-e-i-d closed 2 years ago

j-r-e-i-d commented 2 years ago

Small screencast here showing checkboxes not rendering properly. https://www.dropbox.com/s/7vxxzt3s2omnrk1/Screen%20Recording%202022-04-03%20at%2016.47.06.mov?dl=0

spcbfr commented 2 years ago

I just noticed this too, I am not sure if it's intentional or not

Signynt commented 2 years ago

This issue was fixed on desktop (insider) for me with v.1.4.5 (issue #107), but I also still have the issue on mobile (Android and iOS, both with the most recent release, as well as the most recent insider version).

lguenth commented 2 years ago

I had the same issue (Desktop insider as well) but I just checked to see that it was also fixed after upgrading. I have not tested it on mobile.

mellowbunstar commented 2 years ago

Same thing as well on the Insider build on both Desktop (Mac) and Mobile (iOS).

Screen Shot 2022-04-03 at 1 03 31 PM

Love this theme! :D

danielnichols commented 2 years ago

It seems that a certain variable name has changed in the insider build:

Public version:

input[type=checkbox] {
  height: calc(3px + var(--editor-font-size));
  width: calc(3px + var(--editor-font-size));
}

Insider version:

input[type=checkbox] {
  height: calc(3px + var(--font-text-size)); 
  width: calc(3px + var(--font-text-size)); 
}

For now adding the following to a snippet should fix this for both the current version and the insider version (though I haven't tested the insider version)

/* checkbox-temp-fix.css */
input[type=checkbox] {
  height: calc(3px + var(--font-text-size, var(--editor-font-size)));
  width: calc(3px + var(--font-text-size, var(--editor-font-size)));
}
gabb0z commented 2 years ago

Thank you Daniel, that solved the issue for me (client desktop, mac)

It seems that a certain variable name has changed in the insider build:

Public version:

input[type=checkbox] {
  height: calc(3px + var(--editor-font-size));
  width: calc(3px + var(--editor-font-size));
}

Insider version:

input[type=checkbox] {
  height: calc(3px + var(--font-text-size)); 
  width: calc(3px + var(--font-text-size)); 
}

For now adding the following to a snippet should fix this for both the current version and the insider version (though I haven't tested the insider version)

/* checkbox-temp-fix.css */
input[type=checkbox] {
  height: calc(3px + var(--font-text-size, var(--editor-font-size)));
  width: calc(3px + var(--font-text-size, var(--editor-font-size)));
}
ceciliamay commented 2 years ago

Hey folks! Sorry for being a bit late, I was away. I just got back and quickly patched this. It should be working but please tell me if it isn't! Thank you so much for the team work here!! v.1.4.6 :)

Signynt commented 2 years ago

I'm so sorry, but it's still broken on mobile! ;-;

ceciliamay commented 2 years ago

I'm so sorry, but it's still broken on mobile! ;-;

Okay so it was a typo on the variable - apologies again 😂 - how about now? Is it good?

Signynt commented 2 years ago

You were too fast 😆 It good now!

mellowbunstar commented 2 years ago

Yay, thank you @ceciliamay! 🎉

j-r-e-i-d commented 2 years ago

thank you @ceciliamay

John-Miller12 commented 2 years ago

This issue has occcurred for me in 0.14.15 on Windows. Is a new Issue required?

This resolved the issue:

  height: calc(3px + var(--font-text-size, var(--editor-font-size)));
  width: calc(3px + var(--font-text-size, var(--editor-font-size)));