Upgrade theme to obsidian 1.0

[inhji]

@hellerbarde The patch by @pastordan also fixes the squished sidebar buttons, maybe you could incorporate these as well :)

https://github.com/ceciliamay/obsidianmd-theme-primary/issues/154#issuecomment-1231864095

[GeorgeGo]

Am I testing this incorrectly? When using the css file in my themes folder, headers aren't retaining their colors and showing up as default black.

[pastordan]

George: are you using this code?

.theme-dark .modal .modal-content .vertical-tab-header, .theme-dark .modal .modal-content .vertical-tab-content-container .vertical-tab-content { background-color: var(--background-secondary) !important; }

If so, try changing --background-secondary to --background-primary and see what happens.

On Tue, Oct 25, 2022 at 10:15 AM George Gosieski @.***> wrote:

Am I testing this incorrectly? When using the css file in my themes folder, headers aren't retaining their colors and showing up as default black.

— Reply to this email directly, view it on GitHub https://github.com/ceciliamay/obsidianmd-theme-primary/pull/168#issuecomment-1290731395, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2C6QAH6S3XLX5NJAT6GFTWE72SHANCNFSM6AAAAAARMSW2AA . You are receiving this because you were mentioned.Message ID: @.***>

[hellerbarde]

@GeorgeGo No, you are correct, that is one of the (many) as-of-yet-unresolved issues. (this is after all a "draft" pull request ;) ) I'm not the original theme developer and I'm not familiar with Obsidian theming, so unless @ceciliamay wants to jump in and push this forward, it'll be somewhat slow going. Additionally, I'll have very limited time this week.

I'll also quickly mention this: while it is much appreciated to have everyone help with snippets, it would be even more useful for you to also identify the place they might need to go in the original code (inside the /scss/ folder.)

[hellerbarde]

@inhji Thanks a lot for the suggestion, I'm working on incorporating this. Unfortunately, I don't remember how the side ribbon buttons looked originally, especially on hover. embarrassed

[pastordan]

@hellerbarde You know that Cecilia's working on an update, yes?

Anyway, I believe this bit:

.workspace-ribbon.mod-left:before {
padding-bottom: 19px;
}

div.side-dock-actions {margin-top: 19px;
}

goes in _side-dock-ribbon.scss

This goes in _tab-header.scss:

.mod-left-split .workspace-tab-header-container-inner, .mod-right-split
.workspace-tab-header-container-inner {
gap: 10px;
}

div.workspace-tab-header {
padding-right: 5px !important;
padding-left: 5px !important;
}

And all of this goes in _md-lists.scss, of course:

.md-bullet-color-muted.theme-light span.cm-formatting.cm-formatting-list,
.md-bullet-color-muted.theme-light span.list-bullet,
.md-bullet-color-muted.theme-light li::marker,
.md-bullet-color-muted.theme-dark span.cm-formatting.cm-formatting-list,
.md-bullet-color-muted.theme-dark span.list-bullet,
.md-bullet-color-muted.theme-dark li::marker,
markdown-rendered.list-bullet, list-bullet {
color: var(--background-secondary);
}

svg.svg-icon.lucide-edit-3 path:first-of-type {
color:  var(--callout-title-background);
}

I had some other stuff for callouts, but that's really just customizing for myself.

[hellerbarde]

Oh, yeah, I'm aware. I'm just doing this for myself and why not put it out there for y'all.

[GeorgeGo]

Oh, yeah, I'm aware. I'm just doing this for myself and why not put it out there for y'all.

Greatly appreciate the effort. 🙌

[inhji]

@GeorgeGo No, you are correct, that is one of the (many) as-of-yet-unresolved issues. (this is after all a "draft" pull request ;) ) I'm not the original theme developer and I'm not familiar with Obsidian theming, so unless @ceciliamay wants to jump in and push this forward, it'll be somewhat slow going. Additionally, I'll have very limited time this week.

I'll also quickly mention this: while it is much appreciated to have everyone help with snippets, it would be even more useful for you to also identify the place they might need to go in the original code (inside the /scss/ folder.)

I'm also not familiar with obsidian themes, but I want to look at the Primary source and see if I can help out. It's just a great theme and I'm missing it. 😄

[merfed]

I have been looking and for the life of me cannot figure out why when using split panes, the left pane is offset higher than the right. And then oddly over time both sides will ride upwards.

[pastordan]

This bit drove me up a wall too.

On Fri, Oct 28, 2022 at 2:05 PM merfed @.***> wrote:

I have been looking and for the life of me cannot figure out why when using split panes, the left pane is offset higher than the right. And then oddly over time both rides will ride upwards.

— Reply to this email directly, view it on GitHub https://github.com/ceciliamay/obsidianmd-theme-primary/pull/168#issuecomment-1295353780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2C6QBNNF3S2JE56CZTHJDWFQPV5ANCNFSM6AAAAAARMSW2AA . You are receiving this because you were mentioned.Message ID: @.***>

[ceciliamay]

Hey guys, the new design is a bit challenging with the same reason you guys have mentioned. So I'm pushing all the pull requests to see if these can help! I appreciate all the contributions and the discussion here! I'm also doing a bit of codebase rebuild because I found that some files were a bit all over the place and confusing. I want to open the theme to invite other contributors so that if they want a support a plugin for the theme they can easily do so. I will close and squash this but please feel free to keep the convo going! I'm asking because I'm also rebuilding the README, with a section to explain how to contribute.

I will also be moving the theme to a different owner (Primary Theme org) so it might go missing/broken for a few days - apologies!

[merfed]

Scrollbar Fix:

Add to _var_global.scss:
--size-2-2: 4px;

Replace in _scrollbars.scss:
body:not(.native-scrollbars) ::-webkit-scrollbar,
body:not(.native-scrollbars) .graph-controls::-webkit-scrollbar {
    visibility: visible;
    width: var(--size-2-2);
    height: var(--size-2-2);
    border-radius: 0;
    display: inherit;
    background: var(--scrollbar-bg);
}

body:not(.native-scrollbars) ::-webkit-scrollbar {
    &-thumb {
        visibility: visible;
        background: var(--scrollbar-thumb-bg);
        border-radius: 0;

        &:active {
            background: var(--scrollbar-active-thumb-bg);
            border-radius: 0;
        }
    }
}

I think the scrollbars were just missing the --- before the var name.

[merfed]

Fix shifting split panes:

Replace in _resize-handles.scss:

&-vertical > * >,
    &-left-split >,
    &-right-split > {
        & .workspace-leaf-resize-handle {
            width: 3px;
            height: 105%;
            // top: -24px;
            border-color: var(--background-modifier-border);
            transition: var(--duration-fast-2)
                        var(--motion-smooth);

            &:hover {
                width: 4px;
                border-color: var(--background-modifier-border);
                transition: var(--duration-fast-2)
                            var(--motion-smooth);
            }

            &:active {
                width: 5px;
                transition: var(--duration-fast-2)
                            var(--motion-smooth);

                .theme-light & { /* VH for Light Mode */
                    border-color: var(--color-l-gray-50);
                }

                .theme-dark & { /* VH for Dark Mode */
                    border-color: var(--color-d-gray-30);
                }
            }
        }
    }

[SalahAdDin]

How is this going on?

[gbolo]

My fav theme by far, thanks @ceciliamay . I hope it gets 1.0 compatibility.