primary-theme / obsidian

Comfy, playful but productive theme for Obsidian. "Primary instantly puts you in a relaxed state that opens the door to creativity and exploration. Wonderfully executed down to the smallest details,"
GNU General Public License v3.0
846 stars 38 forks source link

Difficult to see selected text vs unselected text #202

Open SkepticMystic opened 1 month ago

SkepticMystic commented 1 month ago

Related to #66, but not just for highlighted text.

The contrast for selected text in the editor is quite low, making it difficult to tell what exactly is selected. Dark mode is better:

image

But light mode is particularly difficult:

image

ceciliamay commented 1 month ago

CleanShot 2024-05-22 at 15 29 37@2x

CleanShot 2024-05-22 at 15 28 59@2x

would this be better? or is it too light?

SkepticMystic commented 1 month ago

Haha that seems even harder to tell 😅 it might just be my screen, but I literally cannot see what text you have selected there

ceciliamay commented 1 month ago

i think it's very faint myself haha! what do you think about inverting the colors?

Image

Image

im wondering if its too much and if it moves away from the design language. probably will iterate on this and try some other solutions but wanted to know what you think of it since I agree that the text selection should be improved.

SkepticMystic commented 1 month ago

Woh, that's certainly more readable! Perhaps too intense tho, as you say. Ummm I kinda like it? I personally wouldn't be offended at the change, but I also don't know what the phrase "design language" means, so grain of salt :p

I checked on a different device, and can confirm that my original screen is particularly bad at contrast. It's easier to read on mobile.

ceciliamay commented 1 month ago

Noted hehe! I'm still iterating on this and came up with these. I'm thinking that the one below seems to be a mix of both original and the iteration above? what do you think?

CleanShot 2024-05-24 at 11 56 48@2x

CleanShot 2024-05-24 at 11 57 53@2x

SkepticMystic commented 1 month ago

Nice yeah, those are much clearer, and not too intense. I'd argue for a smidge more contrast (particularly in dark mode), but this is much better

ceciliamay commented 1 month ago

thought so too! just increased a lil more contrast for dark mode. will add it to the next release! thank you so much for your input 🙏

SkepticMystic commented 1 month ago

Awesome, thank you :)