search

prime-8-consulting / meteor-oauth2

60 stars 20 forks source link

HL7 FHIR Flowchart #6

Closed awatson1978 closed 8 years ago

awatson1978 commented 8 years ago

I and about 5 or 6 clients are trying to implement the HL7 FHIR spec, which relies on OAuth2, and are referencing the following diagram:

FHIR, Oauth2 and the Mobile client

The above diagram differs a bit from the web sequence diagrams found at www.websequencediagrams.com and what's in the source code.

I'm 95% sure these are all compatible diagrams, but could you confirm where in the above diagram the resourceOwner is understood to be? I'm a little confused as to whether it would be

a) between the Embedded Browser and Authorization Server b) a synonym for the Embedded Browser c) a synonym for the Desktop App/Mobile d) a synonym for the User e) the unlabeled lavendar zone

I'm going to update this diagram accordingly for the ClinicalMeteor HL7 FHIR resources; and would like the source code and documentation to all be in alignment.

vangorra commented 8 years ago

In this diagram, the "resourceOwner" would be both the "Authentication Server' and "Resource Server".

Based on your questions, it seems clear that I have named the examples incorrectly.

The naming convention used for the example of this app seem off. Please chime in on #8 so we can correct this issue.

awatson1978 commented 8 years ago

Okay, first version of the new websequence diagram. Uses the colors and iconography of the overview graph in #7. Has the same level of drill-down as the FHIR diagram. Next step I'd like to do is document the package API calls, like in #4.

oauth - websequence

vangorra commented 8 years ago

I don't see any errors in this chart. The design is fantastic! I look forward to it getting integrated in the docs.

awatson1978 commented 8 years ago

Pull Request #10 just submitted with a revised version of the diagram that includes the OAuth Configuration workflow. I think I'm missing where to add the Redirect URI though. :-/

OAuthWebSequenceWithConfig

awatson1978 commented 8 years ago

Mostly all implemented by #14. Good for me to do an initial handoff to coworkers and stakeholders.

vangorra commented 8 years ago

Great. Now that this diagram is included in the source readme, will you edit the readme to point to the diagram from this repo's source rather than to your fork?