Closed conlanpatrek closed 1 year ago
Addresses #754
Was missing the rotation part.
If you are amenable, I'd also like to make ViewMatrix3d and ProjectionMatrix3d virtual, to support other types of 3d cameras.
For example, I've currently got a camera subclass that is running an orthographic projection.
LMK your opinion and I will either add to this pr or open a new one.
Yeah, by all means make them virtual! Anything that gives more flexibility is fine by me.
Updated
Addresses #754
Was missing the rotation part.
If you are amenable, I'd also like to make ViewMatrix3d and ProjectionMatrix3d virtual, to support other types of 3d cameras.
For example, I've currently got a camera subclass that is running an orthographic projection.
LMK your opinion and I will either add to this pr or open a new one.