Update to Zig 0.8.0 - Githubissues

prime31 / zig-ecs

MIT License

251 stars 39 forks source link

Update to Zig 0.8.0 #10

Closed leroycep closed 3 years ago

leroycep commented 3 years ago

Some of the major changes this version:

HashMap iterator has been changed. I fixed these error in the first commit.
Testing has switched from panicking to gathering a list of error values. Updating to this will mostly require adding try in front of std.testing.expectX, but it will also require any tester functions to be updated to return error codes. This has not been fixed in this pull request at the moment.

leroycep commented 3 years ago

Alright, I added two commits. The first one switches the tests to return errors, though there were a few cases where I didn't know how to return an error from the function so I just added catch unreachable. For example sinks didn't allow returning an error.

The second commit makes the code compatible with an even newer version zig, where unused variables and redundant comptime keywords are disallowed.

This accomplishes what I wanted to do with this PR, so I'm opening it up for review.

prime31 commented 3 years ago

This is looking solid! Awesome job.