primeTanM / Excuser

API of different excuses for different situations.
https://excuser-three.vercel.app/
18 stars 10 forks source link

Add Contributors List in index.html #17

Closed kd1729 closed 2 years ago

kd1729 commented 2 years ago

https://github.com/primeTanM/Excuser/graphs/contributors

Create a contributor list below the image in the area marked by red arrow. Also it should be responsive.

The contributors list should contain the image and name in the same format as shown in below image. Also It should contain the link to that contributor's github profile. The images should be little bit smaller than the images shown in below sscreenshot.

Make a different contributions section below ours section. Include all the contributors there including us,

image

brupadhyay commented 2 years ago

Okay, Add the "hacktoberfest" "hacktoberfest-accepted" labels to this issue and assign this to me, Contributors section should be different one or I can merge it with both of you

image

kd1729 commented 2 years ago

@brupadhyay Yes, also I have updated the description. Please go through it,

brupadhyay commented 2 years ago

I'll be happy to work on this, If I have some doubts I'll ask here.

kd1729 commented 2 years ago

I'll be happy to work on this, If I have some doubts I'll ask here.

yeah sure. 👍🏻

brupadhyay commented 2 years ago

@onlykingKD assign me!!

kd1729 commented 2 years ago

@brupadhyay A new category of Gaming just got added. So add Gaming category link in index.html, id 801 to 820.

https://github.com/primeTanM/Excuser/blob/f2b198ab5727d3438ecdc550444dc8533aea694c/Excuses_eng.js#L694

brupadhyay commented 2 years ago

Yep, @onlykingKD please see the attachments regarding progress of contributors list image image image image image

I'm about to push changes but please review this before-hand

kd1729 commented 2 years ago

@brupadhyay yeah push it, it will not show on API until I re-deploy it on Heroku so np. I will do the minor tweaks afterwards. Thanks a lot for these 4 contributions and improving this API.

brupadhyay commented 2 years ago

One humble request from myside, @onlykingKD please add "hacktoberfest-accepted" to my all PRs till date, I'm making the PR in two!